Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send email alerts for task invalidation messages. #5958

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Aadesh-Baral
Copy link
Contributor

@Aadesh-Baral Aadesh-Baral commented Jul 3, 2023

closes #5944
This PR does the following:

  • Task validation messages are not sent over emails. They are only saved on database (i.e. These messages are displayed on TM notification pages.)
  • Task invalidation messages are saved on database (i.e Can be viewed on TM notification page). Task invalidation messages will be sent over email if user has enabled Task invalidation emails setting.
  • Task notification setting (Task invalidation emails on frontend) will only control if task invalidation message is sent over email)
  • Renames the title and description of user notification setting related to task validation/invalidation email. Now it is set to match the functionality as:
    tasks_invalidation_emails

-----------------------
This commit does the following:
- Task validation messages are not sent over emails. They are always saved on database (i.e. These messages are displayed on TM notification pages.)
- Task invalidation messages are always saved on database (i.e Can be viewed on TM notification page). Task invalidation messages will be sent over email if user has enabled `task notification` email.
- Task notification setting (Task validation emails on frontend) will only control if task invalidation message is sent over email)
…ings page.

----------------------------------------------
`Task Validation emails` and it's description is changed on user settings page to reflect changes made on commit ffb2269.
@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Aadesh-Baral Aadesh-Baral marked this pull request as ready for review July 3, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to validation notification
2 participants