Fixed newlines on windows following footnotes from https://docs.pytho…#5
Open
visch wants to merge 2 commits intohotgluexyz:masterfrom
Open
Fixed newlines on windows following footnotes from https://docs.pytho…#5visch wants to merge 2 commits intohotgluexyz:masterfrom
visch wants to merge 2 commits intohotgluexyz:masterfrom
Conversation
Member
|
Will validate this locally, thanks! |
Author
|
This is now fixed in main already! |
Author
|
This isn't fixed, @hsyyid anyway we can get this merged, just hit this again :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Closes #4
Manual QA steps
Ran locally on my windows box. It works :D
Risks
None seemingly from reading https://docs.python.org/3/library/csv.html#id1
Rollback steps