Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoloading for composer use case without breaking pear #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ralflang
Copy link
Member

Packages need to update to the new doc/template/Horde/Test/packagetest/alltests.php and bootstrap.php for this to work.

Also, horde_test must be require-dev'ed

@yunosh
Copy link
Member

yunosh commented Mar 19, 2019

  1. Please don't change composer.json, it's generated automatically. If we need to change anything there, it must happen in horde-components.
  2. Once we make Horde composer-installable, we should install all dependencies with composer too, instead of bundling them. To make this happen we also need to update to a composer-installable PHPUnit version. Just keep this in mind, even though it may make sense to not do all these changes at once.

@ralflang
Copy link
Member Author

  1. This is actually the output of the horde-components composer command from my patched "maintaina" git tree. I am really looking for a way to communicate that tree as a whole. Basically I have created a composer plugin for horde apps (needed because of web-visible parts) and horde libraries (mostly for js / core handling, but also handy for db migration files). See also thread in horde@

  2. Totally agree, bundling is more of a pear-ready workaround and should be avoided if possible. Distributions also don't like it. It's just I cannot move all parts at the same time without losing focus.

ralflang pushed a commit that referenced this pull request Oct 24, 2023
added TestCase::getMockDependencies method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants