Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align ISwap interface to Swap implementation #95

Closed
wants to merge 1 commit into from
Closed

fix: align ISwap interface to Swap implementation #95

wants to merge 1 commit into from

Conversation

charlesndalton
Copy link

No description provided.

@miguelmota
Copy link
Member

miguelmota commented Mar 1, 2022 •
edited
Loading

@red-impala check out the v1 branch which is the current live implementation

contracts/contracts/saddle/Swap.sol

Line 317 in 8cefc39

function calculateRemoveLiquidity(address account, uint256 amount)

@cwhinfrey @shanefontaine wondering if we should default to v1 since it may be confusing

edit: was looking at the wrong file but the PR is still valid I think for v1 branch

@charlesndalton charlesndalton changed the base branch from master to v1 March 4, 2022 15:21
@charlesndalton charlesndalton changed the base branch from v1 to master March 4, 2022 15:22
@charlesndalton
Copy link
Author

@miguelmota Ok, will create the PR on v1 since I see it has the same problem

@charlesndalton
Copy link
Author

PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesndalton @miguelmota