fix: account for burst in rate limit #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexluong
commented
Sep 27, 2025
Comment on lines
+102
to
+110
| // Performance Trade-offs: | ||
| // - This rate limiter works well for large Terraform states (200+ resources) | ||
| // - However, it significantly impacts small deployments: | ||
| // - 100 resources now take ~30 seconds vs ~5 seconds previously | ||
| // - This is an intentional trade-off for reliability and compliance | ||
| // - Future optimization could implement a true "240 requests per sliding minute" | ||
| // window instead of the current token bucket approach | ||
| // - Potential solution: In-memory FIFO queue that tracks the last minute's | ||
| // requests and blocks when 240 requests have been made in the past 60 seconds |
Collaborator
Author
There was a problem hiding this comment.
just want to call this out as a tradeoff in the current implementation of the rate limit logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.