fix(sdks): correct Python speakeasy pagination config to reference OpenAPI parameter name #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enAPI parameter name The x-speakeasy-pagination configuration was referencing 'next_cursor' but should reference 'next' (the original OpenAPI parameter name) because x-speakeasy-name-override only affects generated code, not the OpenAPI spec itself. The pagination configuration is validated against the OpenAPI spec, so it must use the actual parameter names from the spec.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in the Speakeasy SDK pagination configuration for Python. The pagination configuration incorrectly referenced next_cursor (the renamed parameter in generated code) instead of next (the actual OpenAPI parameter name). Since x-speakeasy-name-override only affects code generation and not the OpenAPI spec itself, the pagination configuration must reference the original parameter names.
Changes:
- Updated pagination configuration to use
nextinstead ofnext_cursorin both events endpoints - Added explanatory comments documenting why the original parameter name must be used
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The x-speakeasy-pagination configuration was referencing 'next_cursor' but should reference 'next' (the original OpenAPI parameter name) because x-speakeasy-name-override only affects generated code, not the OpenAPI spec itself. The pagination configuration is validated against the OpenAPI spec, so it must use the actual parameter names from the spec.