test: fix flaky tests & improve overall test dx #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexluong
changed the title
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
The batching exporter could cause spans to not be flushed before assertions ran, leading to intermittent test failures when running multiple packages in parallel.
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Change TEST default from $(go list ./...) to ./... to fix "malformed import path: invalid char '\n'" error. The go list command outputs newline-separated packages which breaks when passed as an environment variable to scripts/test.sh. Using the glob pattern ./... lets gotestsum handle expansion internally. Issue surfaced during cherry-pick conflict resolution when test targets were refactored to use scripts/test.sh. Co-Authored-By: Claude Opus 4.5 <[email protected]>
alexluong
added a commit
that referenced
this pull request
Jan 15, 2026
* fix: set updated_at on tenant creation The PUT tenant endpoint returned a nullish updated_at (0001-01-01T00:00:00Z) when creating a new tenant because UpdatedAt wasn't initialized. Now both CreatedAt and UpdatedAt are set to the same timestamp on creation. * fix: set updated_at on destination creation * test: verify updated_at in creation response directly The e2e test was checking timestamps after a GET request, which would pass due to entity store fallbacks. Now checks the PUT/POST response directly to catch bugs where updated_at isn't set before returning. * test: fix flaky tests & improve overall test dx (#623) * chore: ignore .envrc for personal direnv usage * refactor: use dedicated testcontainers for RediSearch tests Co-Authored-By: Claude Opus 4.5 <[email protected]> * test: skip redundant backend tests by default (TESTCOMPAT=1) Co-Authored-By: Claude Opus 4.5 <[email protected]> * perf: parallelize e2e tests, skip redundant PG suite Co-Authored-By: Claude Opus 4.5 <[email protected]> * test: add fail-fast to e2e suite, use require over assert Co-Authored-By: Claude Opus 4.5 <[email protected]> * fix: use synchronous span export in test tracer to prevent flaky tests The batching exporter could cause spans to not be flushed before assertions ran, leading to intermittent test failures when running multiple packages in parallel. * refactor: add scripts/test.sh with core test runner logic * refactor: add unit, e2e, and full commands to test.sh * refactor: simplify Makefile test targets to use scripts/test.sh Co-Authored-By: Claude Opus 4.5 <[email protected]> * docs: update test.md for unified test runner * docs: testinfra explanation * chore: remove `make test/integration` * fix: use glob pattern for TEST default in Makefile Change TEST default from $(go list ./...) to ./... to fix "malformed import path: invalid char '\n'" error. The go list command outputs newline-separated packages which breaks when passed as an environment variable to scripts/test.sh. Using the glob pattern ./... lets gotestsum handle expansion internally. Issue surfaced during cherry-pick conflict resolution when test targets were refactored to use scripts/test.sh. Co-Authored-By: Claude Opus 4.5 <[email protected]> --------- Co-authored-by: Claude Opus 4.5 <[email protected]> * chore: add gofmt check to build target --------- Co-authored-by: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TESTCOMPAT=1flagmake testDX using./scripts/test.sh