-
Notifications
You must be signed in to change notification settings - Fork 57
feat(build): add a new Vercel build adapter #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: f66da1b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @justblender Thank you for the PR. I've left some comments. Please check them. |
|
@yusukebe regarding other comments, would you like to have a follow-up PR for these changes? I thought it would be fine to sneak in some minor type changes and JSDoc fixes along with this PR 🫠 |
|
Plus, please add proper tests to |
Yes. Please. |
yusukebe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hi @justblender Thank you for the PR and the quick fixes. Looks good. I'll merge this and release a new version. I appreciate your contribution! |
|
Hold on, got some changes in |
|
Oops. Please create another PR. |
|
@yusukebe there seems to be an issue with this adapter, |
I ended up manually parsing the body from |
This PR introduces a new Vercel build adapter for
@hono/vite-build.The adapter compiles Hono apps to meet the Vercel Build Output API specifications with output files emitting in
.vercel/outputdirectory. It is designed for Vercel Serverless Functions and does not support Edge Runtime, which is being phased out in favor of Vercel's Fluid compute architecture.The default export uses
@hono/node-server/verceladapter. Unfortunately, contrary to the official Vercel documentation, Node.js runtime still expects anode:httpsignature. Perhaps I'm mistaken or did something wrong, but none of the other variants (like usinghono/vercel) produced a working function which wouldn't crash during runtime.