feat: Add recordException helper function
#431
Merged
+76
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Tracer, | ||
| } from '@opentelemetry/api'; | ||
| import { | ||
| ATTR_EXCEPTION_MESSAGE, |
There was a problem hiding this comment.
just checking, but the attribute keys would remain the same right?
There was a problem hiding this comment.
yes they're the same! just a different variable name!
jairo-mendoza
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Currently, error auto-instrumentation works well for uncaught errors but it is also useful to have a helper function that sends an exception span that can be called whenever needed for handled exceptions.
Short description of the changes
recordExceptionhelper function that takes an error and creates an exception span for that error.How to verify that this has the expected result