fix: add opentelemetry/core as a dependency to package.json #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aghassi
force-pushed
the
patch-1
branch
2 times, most recently
from
082eb2b to
ae4275f
Compare
Aghassi
changed the title
|
Thank you so much for your contribution! Since this is being imported directly by the source code, could you update it to be a direct dependency instead? |
Solves honeycombio#127 This will fix support for package managers like `pnpm` that require you to be very explicit about your dependencies
|
@pkanal done |
Aghassi
changed the title
|
@Aghassi due to some setup issues on our side, forked PRs are not running the CircleCI workflow. I have just updated it to run but I think I will have to close / reopen this PR. Going to try that now. |
MustafaHaddara
added a commit
that referenced
this pull request
May 1, 2024
Solves #127 Closes #128 This will fix support for package managers like `pnpm` that require you to be very explicit about your dependencies ## Which problem is this PR solving? Closes #128 @Aghassi contributed a fix in that PR but we merged other PRs and created merge conflicts. This PR resolves those merge conflicts on their behalf. Co-authored-by: David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #127
This will fix support for package managers like
pnpmthat require you to be very explicit about your dependenciesWhich problem is this PR solving?
package.jsonis missing@opentelemetry/coreinpeerDependencies#127Short description of the changes
Abides by requirements outlined here https://pnpm.io/how-peers-are-resolved
Given this package doesn't produce a bundle and is distributed using transpiled source code you still need the dependency manager to have the user resolve what is imported. The source code of this project directly imports this package https://github.com/search?q=repo%3Ahoneycombio%2Fhoneycomb-opentelemetry-web%20%22%40opentelemetry%2Fcore%22&type=code, thus this project relies on its presence.
How to verify that this has the expected result
Import this project and try to run it through webpack using
pnpmas the package manager for the project. It will fail because the package I'm adding in this diff is never resolved in node_modules