Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: various small fixes to core swift SDK #28

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

beekhc
Copy link
Collaborator

@beekhc beekhc commented Jan 14, 2025

Which problem is this PR solving?

These are various small cleanups as we prepare for an eventual beta release.

Short description of the changes

  • Updated CHANGELOG.md with all changes since last release.
  • Updated OTel to 1.12.1.
  • Updated RELEASING.md to better match this repo's process.
  • Removed old TODOs from Honeycomb.swift. Some were fixed already, and others were deprioritized.
  • Changed debug options to print all options, rather than just a handful.
  • Stopped hard-coding otlpVersion since that's fixed upstream.
  • Removed a constructor that is now redundant for HoneycombOptions.

How to verify that this has the expected result

Smoke tests and unit tests still pass. Manually verified debug output is reasonable.

@beekhc beekhc requested a review from a team as a code owner January 14, 2025 01:16
Copy link

@wolfgangcodes wolfgangcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@beekhc beekhc force-pushed the beeklimt.core-cleanup branch from f4183ce to 022ed5b Compare January 14, 2025 17:28
@beekhc beekhc merged commit 0a7861f into main Jan 14, 2025
6 checks passed
@beekhc beekhc deleted the beeklimt.core-cleanup branch January 14, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants