Update fork to match upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement xml-roundtrip-validator
|
unfortunately upstream didn't implement them the way we need, so we'll still be on the hook for figuring out how to make it work for our use-case (either instead of the way upstream does it or some way to support both). Upstream did implement RSA1.5 transport, but only for TripleDES keys. We need it for AES keys. |
toshok
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in recent changes since forking (last update currently in
masteris from Feb 2020). The only deviation I could find to resolve is this PR, but it looks like the changes in that PR are already implemented in the most recent version of the upstream main branch (would appreciate a 👍🏼 / second set of eyes on that though to make sure).I ran the hound go tests using this package locally with my go.mod pointed to this updated version, and they all passed. My plan from here is to merge this in, tag it as a new release, and then create a hound branch updating go.mod to point to the new-release version of this repo for its own PR/testing.
Asana: Resolve Critical Security Issues with russellhaering/gosaml2 and russellhaering/goxmldsig