Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dockerize python services #622

Merged
merged 3 commits into from
May 22, 2023
Merged

feat: dockerize python services #622

merged 3 commits into from
May 22, 2023

Conversation

vreynolds
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • use dockerized python services in tilt
  • consolidate running docs in the root readme
  • switch py to python moniker when interacting with tilt

How to verify

tilt up python

@vreynolds vreynolds requested a review from a team May 19, 2023 19:34
@vreynolds vreynolds changed the title Vera.dockerize python feat: dockerize python services May 19, 2023
@vreynolds vreynolds self-assigned this May 19, 2023
@vreynolds vreynolds added the type: enhancement New feature or request label May 19, 2023
Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works 🎉 but takes about 5 minutes on my mac m2. I realize the base image wasn't changed here but since we're doing this, can we change in the same PR? alpine took 5 minutes compared to slim which took about 17s

suggest changing from this:

FROM python:3.10-alpine
WORKDIR /app
RUN apk add --no-cache gcc musl-dev python3-dev libffi-dev openssl-dev cargo

to this:

FROM python:3.10-slim
WORKDIR /app

(no need to install the other libraries with this image)

@vreynolds vreynolds requested a review from JamieDanielson May 22, 2023 20:52
@JamieDanielson JamieDanielson merged commit 5d9714e into main May 22, 2023
@JamieDanielson JamieDanielson deleted the vera.dockerize-python branch May 22, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants