Fix: download images from posts with emoji-only, extra long, exotic emoji containing titles #5478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarrick
changed the title
Tarrick
changed the title
It's more expansive than a simple emoji removal even though sometimes it leaves behind unprintable characters like the tags of regional flags. The latter should be cared for by the following Unicode class escape replacement.
Tarrick
changed the title
uwx
added a commit
to uwx/Reddit-Enhancement-Suite
that referenced
this pull request
Nov 13, 2023
…emoji-only, extra long, exotic emoji containing titles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in browser: Google Chrome 112.0.5615.165
Adjusted checks and replacements for titles of saved images
Examples of images from posts can be downloaded with the fix:
Long title: https://www.reddit.com/r/Steam/comments/116atn0/steam_is_constantly_taking_screenshots_while/
Emoji-only: https://www.reddit.com/r/electricians/comments/xay4ar/_/
Multicharacter emoji: https://www.reddit.com/r/AutumnPorn/comments/16yop1v/castle_combe_wiltshire_england/
Starting with a period: https://www.reddit.com/r/Moescape/comments/18lq49l/by_homutan_original/