prevent neverEndingComments from loading duplicate comments #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: https://www.reddit.com/r/Enhancement/comments/l1boqd/comments_duplicating_in_never_ending_reddit/
Tested in browser: chrome, firefox
To reproduce:
/api/morechildrenrequest to sendloading...text exits the bottom of the viewport/api/morechildrenrequest should be sent, causing duplicate comments.Solution is to ensure that the same loader link is never clicked twice.
My implementation checks if the loader link has the
loadingtext, if so then ignore it.It works, but will there be any issues with translations? Like will the
loadingtext check fail for spanish users, etc?