Skip to content

Conversation

@ptarjan
Copy link

@ptarjan ptarjan commented Dec 8, 2025

Proposed change

When creating backups, now stores mount configurations (CIFS/NFS shares) including server, share, credentials, and other settings. When restoring from a backup, mount configurations are automatically restored.

This fixes the issue where network storage definitions for backups were lost after restoring from a backup, requiring users to manually reconfigure their network storage mounts.

Changes:

  • Add ATTR_MOUNTS schema to backup validation
  • Add store_mounts() method to save mount configs during backup
  • Add restore_mounts() method to restore mount configs during restore
  • Add MOUNTS stage to backup/restore job stages
  • Update BackupManager to call mount backup/restore methods
  • Add tests for mount backup/restore functionality

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints or add-on configuration are added/changed:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @claude

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft December 8, 2025 15:18
@home-assistant
Copy link

home-assistant bot commented Dec 8, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@ptarjan ptarjan force-pushed the claude/submit-external-patch-01AL1gq8p9HKozCu4K1MRDTk branch from 404f6d2 to ec11578 Compare December 8, 2025 15:19
@ptarjan ptarjan marked this pull request as ready for review December 8, 2025 15:20
When creating backups, now stores mount configurations (CIFS/NFS shares)
including server, share, credentials, and other settings. When restoring
from a backup, mount configurations are automatically restored.

This fixes the issue where network storage definitions for backups
were lost after restoring from a backup, requiring users to manually
reconfigure their network storage mounts.

Changes:
- Add ATTR_MOUNTS schema to backup validation
- Add store_mounts() method to save mount configs during backup
- Add restore_mounts() method to restore mount configs during restore
- Add MOUNTS stage to backup/restore job stages
- Update BackupManager to call mount backup/restore methods
- Add tests for mount backup/restore functionality

Fixes home-assistant/core#148663
@ptarjan ptarjan force-pushed the claude/submit-external-patch-01AL1gq8p9HKozCu4K1MRDTk branch from ec11578 to e6778d7 Compare December 8, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restoring from backup doesn’t restore some settings

1 participant