Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamic device access cgroup #3421

Merged
merged 5 commits into from
Jan 26, 2022
Merged

Support dynamic device access cgroup #3421

merged 5 commits into from
Jan 26, 2022

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Jan 26, 2022 •
edited
Loading

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@pvizeli pvizeli added the new-feature A new feature label Jan 26, 2022
@pvizeli pvizeli changed the title Hw-addons Support dynamic device access cgroup Jan 26, 2022
agners
agners approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

supervisor/docker/addon.py Show resolved Hide resolved
@pvizeli pvizeli merged commit caacb42 into main Jan 26, 2022
@pvizeli pvizeli deleted the hw-addons branch January 26, 2022 15:48
@jens-maus jens-maus mentioned this pull request Jan 26, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agners agners agners approved these changes

Assignees
No one assigned
Labels
cla-signed new-feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add-on with "devices:" config entry does not allow to access device nodes anymore
3 participants
@pvizeli @agners @homeassistant