Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] Adds set as alias to turn #2352

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
2 changes: 1 addition & 1 deletion sentences/en/_common.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ expansion_rules:
where_is: "(where's|wheres|where is)"
brightness: "{brightness}[[ ]%| percent]"
light: "[the] (light|lights|lighting)"
turn: "(turn|switch|change)"
turn: "(turn|switch|change|set)"
temp: "(temp|temperature)"
temperature: "{temperature}[([ ]°[ ][{temperature_unit}])|( degrees[ {temperature_unit}])]"
open: "(open|raise)"
Expand Down
10 changes: 5 additions & 5 deletions sentences/en/fan_HassTurnOff.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ intents:
- sentences:
- "<turn> off [all] [the] fan[s] in <area>"
- "<turn> off <area> fan[s]"
- "[<turn>] [all] <area> fan[s] off"
- "[<turn>] [all] [the] fan[s] [in] <area> off"
- "[<turn>] [all] <area> fan[s] [to] off"
- "[<turn>] [all] [the] fan[s] [in] <area> [to] off"
- "deactivate [all] [the] fan[s] [in] <area>"
- "deactivate [all] <area> [the] fan[s]"
slots:
Expand All @@ -15,7 +15,7 @@ intents:
response: fans_area

- sentences:
- "[<turn>] (all [the] fan[s] off|[the] fan[s] off everywhere)"
- "[<turn>] (all [the] fan[s] off|[the] fan[s] [to] off everywhere)"
- "deactivate (all [the] fan[s]|[the] fan[s] everywhere)"
response: "light_all"
slots:
Expand All @@ -24,8 +24,8 @@ intents:

- sentences:
- "<turn> off[ all][ the] fan[s][<in_here>]"
- "<turn>[ all][ the] fan[s]( off;<in_here>)"
- "<turn>[ all][ the] fan[s] off"
- "<turn>[ all][ the] fan[s] [to]( off;<in_here>)"
- "<turn>[ all][ the] fan[s][ to] off"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderabbitai why isn't the sentence 'Set all the fans to off' being matched to this line?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, something went wrong! Please try again later. 🐰 💔

response: "fans_area"
expansion_rules:
in_here: "[ in] here"
Expand Down
6 changes: 3 additions & 3 deletions sentences/en/fan_HassTurnOn.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ intents:
- sentences:
- "<turn> on [all] [the] fan[s] in <area>"
- "<turn> on <area> fan[s]"
- "[<turn>] [all] <area> fan[s] on"
- "[<turn>] [all] <area> fan[s] [to] on"
- "activate [all] <area> fan[s]"
- "activate [all] fan[s] [in] <area>"
slots:
Expand All @@ -15,8 +15,8 @@ intents:

- sentences:
- "<turn> on[ all][ the] fan[s][<in_here>]"
- "<turn>[ all][ the] fan[s]( on;<in_here>)"
- "<turn>[ all][ the] fan[s] on"
- "<turn>[ all][ the] fan[s] [to] ( on;<in_here>)"
- "<turn>[ all][ the] fan[s] [to] on"
response: "fans_area"
expansion_rules:
in_here: "[ in] here"
Expand Down
16 changes: 8 additions & 8 deletions sentences/en/light_HassTurnOff.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ intents:
- sentences:
- "<turn> off [all] <light> in <area>"
- "<turn> off [all] <area> <light>"
- "[<turn>] [all] <area> <light> off"
- "[<turn>] [all] <light> [in] <area> off"
- "[<turn>] [all] <area> <light> [to] off"
- "[<turn>] [all] <light> [in] <area> [to] off"
- "deactivate [all] <light> [in] <area>"
- "deactivate [all] <area> <light>"
slots:
Expand All @@ -23,13 +23,13 @@ intents:

# Turn off all lights in the home
- sentences:
- "<turn> <all> <light> off <everywhere>"
- "<turn> <all> <light> [to] off <everywhere>"
- "<turn> off <all> <light> <everywhere>"
- "deactivate <all> <light> <everywhere>"
- "<turn> <light> off <everywhere>"
- "<turn> off <light> <everywhere>"
- "deactivate <light> <everywhere>"
- "<turn> <all> <light> off"
- "<turn> <all> <light> [to] off"
- "<turn> off <all> <light>"
- "deactivate <all> <light>"
response: "light_all"
Expand All @@ -40,13 +40,13 @@ intents:
- sentences:
- "<turn> <all> <light> off <here>"
- "<turn> <light> off <here>"
- "<turn> <all> <light> <here> off"
- "<turn> <light> <here> off"
- "<turn> <all> <light> <here> [to] off"
- "<turn> <light> <here> [to] off"
- "<turn> off <all> <light> <here>"
- "<turn> off <light> <here>"
- "deactivate <all> <light> <here>"
- "deactivate <light> <here>"
- "<turn> <light> off"
- "<turn> <light> [to] off"
- "<turn> off <light>"
- "deactivate <light>"
response: "lights_area"
Expand All @@ -61,7 +61,7 @@ intents:
- "<turn> off <all> <light> (on|in) <floor>"
- "<turn> off <all> <light> <floor>"
- "<turn> off <all> <floor> <light>"
- "<turn> <floor> <light> off"
- "<turn> [<all>] <floor> <light> [to] off"
- "<floor> <light> off"
- "deactivate <all> <floor> <light>"
- "deactivate <all> <light> (on|in) <floor>"
Expand Down
14 changes: 7 additions & 7 deletions sentences/en/light_HassTurnOn.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ intents:
- sentences:
- "<turn> on [all] <light> in <area>"
- "<turn> on [all] <area> <light>"
- "[<turn>] [all] <area> <light> on"
- "[<turn>] [all] <light> [in] <area> on"
- "[<turn>] [all] <area> <light> [to] on"
- "[<turn>] [all] <light> [in] <area> [to] on"
- "activate [all] <light> [in] <area>"
- "activate [all] <area> <light>"
slots:
Expand All @@ -29,7 +29,7 @@ intents:
- "<turn> <light> on <everywhere>"
- "<turn> on <light> <everywhere>"
- "activate <light> <everywhere>"
- "<turn> <all> <light> on"
- "<turn> <all> <light> [to] on"
- "<turn> on <all> <light>"
- "activate <all> <light>"
response: "light_all"
Expand All @@ -40,13 +40,13 @@ intents:
- sentences:
- "<turn> <all> <light> on <here>"
- "<turn> <light> on <here>"
- "<turn> <all> <light> <here> on"
- "<turn> <light> <here> on"
- "<turn> <all> <light> <here> [to] on"
- "<turn> <light> <here> [to] on"
- "<turn> on <all> <light> <here>"
- "<turn> on <light> <here>"
- "activate <all> <light> <here>"
- "activate <light> <here>"
- "<turn> <light> on"
- "<turn> <light> [to] on"
- "<turn> on <light>"
- "activate <light>"
response: "lights_area"
Expand All @@ -61,7 +61,7 @@ intents:
- "<turn> on <all> <light> (on|in) <floor>"
- "<turn> on <all> <light> <floor>"
- "<turn> on <all> <floor> <light>"
- "<turn> <floor> <light> on"
- "<turn> [<all>] <floor> <light> [to] on"
- "<floor> <light> on"
- "activate <all> <floor> <light>"
- "activate <all> <light> (on|in) <floor>"
Expand Down
3 changes: 3 additions & 0 deletions tests/en/fan_HassTurnOff.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ tests:
- "turn all the living room fans off"
- "living room fans off"
- "deactivate living room fans"
- "set the living room fans to off"
intent:
name: HassTurnOff
slots:
Expand All @@ -25,6 +26,7 @@ tests:
- Turn all fans off
- Deactivate all fans
- Deactivate the fan everywhere
- Set all the fans to off
intent:
name: HassTurnOff
slots:
Expand All @@ -37,6 +39,7 @@ tests:
- "turn all the fans off in here"
- "turn the fans here off"
- "turn the fans off"
- "set the fans to off"
intent:
name: HassTurnOff
context:
Expand Down
2 changes: 2 additions & 0 deletions tests/en/fan_HassTurnOn.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ tests:
- "all kitchen fans on"
- "kitchen fans on"
- "activate kitchen fans"
- "set the kitchen fans to on"
intent:
name: HassTurnOn
slots:
Expand All @@ -27,6 +28,7 @@ tests:
- "turn all the fans on in here"
- "turn the fans here on"
- "turn the fans on"
- "set the fans to on"
intent:
name: HassTurnOn
context:
Expand Down
4 changes: 4 additions & 0 deletions tests/en/light_HassTurnOff.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ tests:
- "turn the kitchen lights off"
- "kitchen lighting off"
- "deactivate kitchen lights"
- "Set the kitchen lights to off"
intent:
name: HassTurnOff
slots:
Expand All @@ -45,6 +46,7 @@ tests:
- Turn all lighting off
- Deactivate every single light
- Deactivate lights in each room
- Set all the lights to off
intent:
name: HassTurnOff
slots:
Expand All @@ -63,6 +65,7 @@ tests:
- Turn the lights off
- Turn off the lights
- Deactivate the lights
- Set the lights to off
intent:
name: HassTurnOff
context:
Expand All @@ -81,6 +84,7 @@ tests:
- First floor lights off
- Deactivate all first floor lights
- Deactivate all lights on the first floor
- Set all the first floor lights to off
intent:
name: HassTurnOff
slots:
Expand Down
4 changes: 4 additions & 0 deletions tests/en/light_HassTurnOn.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ tests:
- "activate living room lights"
- "lights living room on"
- "living room lighting on"
- "set the living room lights to on"
intent:
name: HassTurnOn
slots:
Expand All @@ -47,6 +48,7 @@ tests:
- Turn all lighting on
- Activate every single light
- Activate lights in each room
- Set all lights to on
intent:
name: HassTurnOn
slots:
Expand All @@ -65,6 +67,7 @@ tests:
- Turn the lights on
- Turn on the lights
- Activate the lights
- Set the lights to on
intent:
name: HassTurnOn
context:
Expand All @@ -83,6 +86,7 @@ tests:
- First floor lights on
- Activate all first floor lights
- Activate all lights on the first floor
- Set all the first floor lights to on
intent:
name: HassTurnOn
slots:
Expand Down
Loading