Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display_order for to-do list card #36989

Merged
merged 1 commit into from
Jan 19, 2025
Merged

display_order for to-do list card #36989

merged 1 commit into from
Jan 19, 2025

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Jan 19, 2025

Proposed change

Document display_order option for todo card.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features
    • Added a new configuration option display_order for to-do list cards
    • Allows customizable sorting of to-do list items (alphabetically, by due date)
    • Default sorting remains in original order if not specified

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jan 19, 2025
Copy link

netlify bot commented Jan 19, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 61caa32
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/678c80ed2e3f140008214fa7
😎 Deploy Preview https://deploy-preview-36989--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Jan 19, 2025

📝 Walkthrough

Walkthrough

The pull request introduces a new configuration option display_order for the to-do list card in the dashboard configuration. This optional field allows users to specify how to-do list items are sorted, with five possible sorting methods: none (default), alpha_asc, alpha_desc, duedate_asc, and duedate_desc. The addition provides more flexibility in presenting to-do list items by enabling different sorting approaches while maintaining the existing configuration structure.

Changes

File Change Summary
source/_dashboards/todo-list.markdown Added new optional YAML configuration field display_order for to-do list card

Sequence Diagram

sequenceDiagram
    participant User
    participant Configuration
    participant TodoList
    
    User->>Configuration: Specify display_order
    Configuration->>TodoList: Apply sorting method
    alt No sorting specified
        TodoList-->>User: Display items in original order
    else Alphabetical Ascending
        TodoList-->>User: Sort items A-Z
    else Alphabetical Descending
        TodoList-->>User: Sort items Z-A
    else Due Date Ascending
        TodoList-->>User: Sort by earliest due date first
    else Due Date Descending
        TodoList-->>User: Sort by latest due date first
    end
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@karwosts karwosts added the parent-merged The parent PR has been merged already label Jan 19, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
source/_dashboards/todo-list.markdown (2)

74-78: Improve the documentation structure and add examples.

While the documentation is technically accurate, consider these improvements for better clarity:

  1. Structure the description as a list for better readability:
-  description: "Optionally sorts the items in the to-do list for display. Options are: `none`: Show the list in its original order. `alpha_asc`: Sort the list in alphabetical order. `alpha_desc`: Sort the list in reverse alphabetical order. `duedate_asc`: Sort the list by due date (soonest first). `duedate_desc`: Sort the list by reverse due date (soonest last)."
+  description: "Optionally sorts the items in the to-do list for display. Available options:\n
+    - `none`: Show the list in its original order\n
+    - `alpha_asc`: Sort the list in alphabetical order\n
+    - `alpha_desc`: Sort the list in reverse alphabetical order\n
+    - `duedate_asc`: Sort the list by due date (soonest first)\n
+    - `duedate_desc`: Sort the list by reverse due date (soonest last)"
  1. Add information about validation behavior for invalid values
  2. Add an example showing the usage:
# Example with display order
type: todo-list
entity: todo.shopping_list
title: Shopping List
display_order: alpha_asc

73-78: Add display_order to the Examples section.

To help users understand how to use this new feature, consider adding an example that demonstrates the display_order configuration in the Examples section at the end of the file. This would complement the existing title example.

# Example with display order and other options
type: todo-list
entity: todo.shopping_list
title: Sorted Shopping List
display_order: alpha_asc
hide_completed: true
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e89149 and 61caa32.

📒 Files selected for processing (1)
  • source/_dashboards/todo-list.markdown (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_dashboards/todo-list.markdown (1)

73-78: Documentation successfully captures the new feature.

The documentation for the display_order option is well-integrated into the existing configuration section and provides clear information about the available sorting options. This aligns well with the PR objectives of documenting this new feature.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @karwosts 👍

../Frenck

@frenck frenck merged commit ed61a54 into next Jan 19, 2025
9 checks passed
@frenck frenck deleted the karwosts-patch-2 branch January 19, 2025 19:50
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Jan 19, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants