Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use statistics data in History graph card to fill gaps #23612

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

MindFreeze
Copy link
Contributor

Proposed change

This makes the history card the same as the history panel

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ildar170975
Copy link
Contributor

Can we make this feature optional?
Assume enabled by default - but it could be disabled by some option.

@MindFreeze
Copy link
Contributor Author

Can we make this feature optional?

Why would someone want to disable this? It only fills missing data from the past in case it has been purged from the recorder.

@ildar170975
Copy link
Contributor

Why would someone want to disable this?

This is clear, I am asking from a point of view of a person who may not be able to see a visual difference between a “history” curve and less vivid “statistics” curve. That is why we probably should add a boolean option for this “augmentation”.

@MindFreeze
Copy link
Contributor Author

I still don't understand but the thing is that if we add any options to this card, people will start requesting them for the history panel too as the card is a mini version of that

@ildar170975
Copy link
Contributor

ildar170975 commented Jan 8, 2025

if we add any options to this card, people will start requesting them for the history panel too as the card is a mini version of that

Agree, but history-graph card also has other options like for min/max bounds, show/hide names which are (obviously) not provided for History page/more-info.
Providing an option for that “augmentation” will add a possibility to see clearly where a real history ends. As I already said - currently for some people it is not clear where it ends because a color difference is slightly visible.

@MindFreeze MindFreeze requested a review from bramkragten January 8, 2025 13:26
@bramkragten
Copy link
Member

This is clear, I am asking from a point of view of a person who may not be able to see a visual difference between a “history” curve and less vivid “statistics” curve. That is why we probably should add a boolean option for this “augmentation”.

I still don't get the reason of having a boolean option then? What would it solve?

@ildar170975
Copy link
Contributor

ildar170975 commented Jan 9, 2025

My proposal was:

  1. Add a new boolean option like “show_ststistics”. Default = true.
  2. If false - then the card will not be “augmented” by LTS.

@bramkragten
Copy link
Member

My proposal was:

  1. Add a new boolean option like “show_ststistics”. Default = true.
  2. If false - then the card will not be “augmented” by LTS.

Yes, I get your suggestion, I just don't understand why you would want it, what problem does it solve?

@ildar170975
Copy link
Contributor

ildar170975 commented Jan 9, 2025

Sometimes to perform an analysis we need to look at the “pure history data”. A visual difference between statistics and history curves is slightly visible which causes a problem for people with damaged eyes (or just old people).

@MindFreeze
Copy link
Contributor Author

Needing to differentiate "pure history data" seems like an edge case for a card. It makes more sense to do this in the history panel. And we could improve the styling to make it more visible.

@MindFreeze MindFreeze merged commit 707192f into dev Jan 10, 2025
15 checks passed
@MindFreeze MindFreeze deleted the history-card-stats branch January 10, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants