-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use statistics data in History graph card to fill gaps #23612
Conversation
Can we make this feature optional? |
Why would someone want to disable this? It only fills missing data from the past in case it has been purged from the recorder. |
This is clear, I am asking from a point of view of a person who may not be able to see a visual difference between a “history” curve and less vivid “statistics” curve. That is why we probably should add a boolean option for this “augmentation”. |
I still don't understand but the thing is that if we add any options to this card, people will start requesting them for the history panel too as the card is a mini version of that |
Agree, but history-graph card also has other options like for min/max bounds, show/hide names which are (obviously) not provided for History page/more-info. |
I still don't get the reason of having a boolean option then? What would it solve? |
My proposal was:
|
Yes, I get your suggestion, I just don't understand why you would want it, what problem does it solve? |
Sometimes to perform an analysis we need to look at the “pure history data”. A visual difference between statistics and history curves is slightly visible which causes a problem for people with damaged eyes (or just old people). |
Needing to differentiate "pure history data" seems like an edge case for a card. It makes more sense to do this in the history panel. And we could improve the styling to make it more visible. |
Proposed change
This makes the history card the same as the history panel
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: