-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support external step for login flow #23204
Open
allenporter
wants to merge
7
commits into
home-assistant:dev
Choose a base branch
from
allenporter:login-external-step
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+122
−15
Open
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5b56570
Support external step for Authentication providers in login flow
allenporter 9c37022
Fix typing to address lint errors
allenporter ab0ad03
Update src/auth/ha-auth-flow.ts
bramkragten 7aa464f
Add check for source and origin
allenporter 34b0cd2
Omit event argument to handleSubmit
allenporter 2d40693
Handle popup blocks and link clicks
allenporter fea5ea7
SImplify using a button instead of an anchor
allenporter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
import type { CSSResultGroup, TemplateResult } from "lit"; | ||
import { css, html } from "lit"; | ||
import { customElement, property } from "lit/decorators"; | ||
import type { DataEntryFlowStepExternal } from "../data/data_entry_flow"; | ||
import { fireEvent } from "../common/dom/fire_event"; | ||
import type { LocalizeFunc } from "../common/translations/localize"; | ||
import { HaForm } from "../components/ha-form/ha-form"; | ||
|
||
@customElement("ha-auth-external") | ||
export class HaAuthExternal extends HaForm { | ||
@property({ attribute: false }) public localize!: LocalizeFunc; | ||
|
||
@property({ attribute: false }) public stepTitle?: string; | ||
|
||
@property({ attribute: false }) public step!: DataEntryFlowStepExternal; | ||
|
||
protected render(): TemplateResult { | ||
return html` | ||
<h2>${this.stepTitle}</h2> | ||
<div class="content"> | ||
${this.localize("ui.panel.page-authorize.external.description")} | ||
<div class="open-button"> | ||
<a href=${this.step.url} target="_blank" rel="opener"> | ||
<mwc-button raised> | ||
${this.localize("ui.panel.page-authorize.external.open_site")} | ||
</mwc-button> | ||
</a> | ||
</div> | ||
</div> | ||
`; | ||
} | ||
|
||
protected firstUpdated(changedProps) { | ||
super.firstUpdated(changedProps); | ||
window.open(this.step.url); | ||
window.addEventListener("message", async (message: MessageEvent) => { | ||
if (message.data.type === "externalCallback") { | ||
fireEvent(this, "step-finished"); | ||
} | ||
}); | ||
} | ||
|
||
static get styles(): CSSResultGroup { | ||
return [ | ||
css` | ||
.open-button { | ||
text-align: center; | ||
padding: 24px 0; | ||
} | ||
.open-button a { | ||
text-decoration: none; | ||
} | ||
`, | ||
]; | ||
} | ||
} | ||
|
||
declare global { | ||
interface HTMLElementTagNameMap { | ||
"ha-auth-external": HaAuthExternal; | ||
} | ||
interface HASSDomEvents { | ||
"step-finished": undefined; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do a check for
origin
andsource
of the message?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sounds good. I have this working for the window.open (following what the previous PR did). How do you track the source of the button that opens the window above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think there is a way with just an anchor link. You could make it a click event and open the window programmatically with
window.open
. Hoping that will not cause issues with popup blockers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK -- I changed this to use a button to run the same code thats run when first loading. Perhaps that is reasonable...