Add Fan mode support to Control4 integration #159980
Draft
+139
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @lawtancool, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
requested changes
Dec 30, 2025
Comment on lines
+285
to
+305
| @property | ||
| def fan_mode(self) -> str | None: | ||
| """Return the current fan mode.""" | ||
| data = self._thermostat_data | ||
| if data is None: | ||
| return None | ||
| return data.get(CONTROL4_FAN_MODE) | ||
|
|
||
| @property | ||
| def fan_modes(self) -> list[str] | None: | ||
| """Return the list of available fan modes.""" | ||
| data = self._thermostat_data | ||
| if data is None: | ||
| return None | ||
| modes = data.get(CONTROL4_FAN_MODES_LIST) | ||
| if modes is None: | ||
| return None | ||
| # Handle both string (comma-separated) and list formats | ||
| if isinstance(modes, str): | ||
| return [m.strip() for m in modes.split(",") if m.strip()] | ||
| return list(modes) if modes else None |
Member
There was a problem hiding this comment.
Okay so how does a control4 system get its fan modes? Are there defaults for that? Can people pick custom ones?
Because ideally if we have fan modes, we make them snake_case and add their translation to strings.json (and icon to icons.json). This way we can show the fan modes localized, but that is only depending on how consistent the source data is.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds support for Auto, Circulate and On modes for fans.
Type of change
Additional information
Set temperature being displayed as 0 will come in another patch.
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: