Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files for bolletta #6233

Merged
merged 6 commits into from
Dec 23, 2024
Merged

Files for bolletta #6233

merged 6 commits into from
Dec 23, 2024

Conversation

StefanoGiu
Copy link
Contributor

@StefanoGiu StefanoGiu commented Dec 17, 2024

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/StefanoGiu/bolletta

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the dark & light versions are the same, and the logo and icon version the same, please than just leave the light icon version. Remove all the others.

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 22, 2024 21:37
@StefanoGiu StefanoGiu marked this pull request as ready for review December 23, 2024 08:23
@home-assistant home-assistant bot requested a review from frenck December 23, 2024 08:23
@StefanoGiu
Copy link
Contributor Author

How can I delete files from the pull request? I'm not an expert

@frenck frenck marked this pull request as draft December 23, 2024 08:29
@frenck
Copy link
Member

frenck commented Dec 23, 2024

By checking out the branch, remove the file, stage those changes, commit them and pushing them out.

../Frenck

@StefanoGiu
Copy link
Contributor Author

How do I do it? May you guide me please?

@StefanoGiu
Copy link
Contributor Author

I'm using the browser Chrome and I don't know how to do it...

@frenck
Copy link
Member

frenck commented Dec 23, 2024

I'm using the browser Chrome and I don't know how to do it...

That will be hard. Please use a git client locally.

@StefanoGiu
Copy link
Contributor Author

I don't know how to use the git client and what commands to issue... Can you help me? Would you be able to remove files on my behalf?

@frenck
Copy link
Member

frenck commented Dec 23, 2024

@StefanoGiu I'm sorry, but I currently lack the time to teach you how to use git.

And honestly, how would you manage maintaining a custom integration if you haven't got that skill? 🤷

Everyone has to learn, that I get. There are tons of resources to be found online on this subject.

../Frenck

@StefanoGiu
Copy link
Contributor Author

What about if I create a new pull request with only the 4 files of the light version?

@StefanoGiu
Copy link
Contributor Author

Please let me know if this is ok

@frenck
Copy link
Member

frenck commented Dec 23, 2024

You should just adjust this PR 🤷

Files deleted
@StefanoGiu
Copy link
Contributor Author

Is it ok now?

@frenck
Copy link
Member

frenck commented Dec 23, 2024

Nope, the logo version can be removed too. As they are the same as the icon version.

Additionally, there seems to be an artifact visible on the 2x versions; could you take a look at that?

Fix
Fix
@StefanoGiu
Copy link
Contributor Author

Fixed

@frenck frenck marked this pull request as ready for review December 23, 2024 20:44
@frenck frenck merged commit 278249b into home-assistant:master Dec 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants