Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added icons for Modbus_Manager #6229

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

TCzerny
Copy link

@TCzerny TCzerny commented Dec 16, 2024

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/TCzerny/ha-modbus-manager

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this integration integrates with Modbus, therefore the Modbus branding is expected. Please adjust the PR to contain the Modbus branding.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft December 16, 2024 18:30
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@TCzerny
Copy link
Author

TCzerny commented Dec 18, 2024

Hi Frenck,
Sorry for that... I guess I miss interpret the documentation for that. Thought that the custom_integrations are not allowed to reuse the brans...
I've created the icons & logo which uses the original modbus icon and added the "Manager" to it...
Hope that's fine? if not let me know.
thanks a lot
TCzerny

@TCzerny TCzerny closed this Dec 18, 2024
@TCzerny TCzerny reopened this Dec 18, 2024
@TCzerny TCzerny requested a review from frenck December 18, 2024 14:29
@TCzerny TCzerny marked this pull request as ready for review December 18, 2024 19:33
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains a modified/custom version of a brand image. This often conflicts with manufacturer branding guidelines, and we therefore cannot accept this.

Please use the original Modbus branding assets instead.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft December 22, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants