Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make panel and panel.io lazy imports #7208

Draft
wants to merge 43 commits into
base: main
Choose a base branch
from
Draft

Make panel and panel.io lazy imports #7208

wants to merge 43 commits into from

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Aug 30, 2024

Honestly, this should not be added to the 1.5 release, as it is too late.

But would not want to delete the changes either.

python -X importtime -c 'import panel' 2> tuna.log && tuna tuna.log
This PR:
image

Speed import PR
image

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 62.12625% with 114 lines in your changes missing coverage. Please review.

Project coverage is 81.99%. Comparing base (d49dafc) to head (0a6d5dd).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
panel/pane/__init__.py 40.54% 22 Missing ⚠️
panel/widgets/__init__.py 37.14% 22 Missing ⚠️
panel/io/__init__.py 48.78% 21 Missing ⚠️
panel/layout/__init__.py 42.85% 16 Missing ⚠️
panel/__init__.py 66.66% 10 Missing ⚠️
panel/config.py 73.91% 6 Missing ⚠️
panel/io/state.py 50.00% 4 Missing ⚠️
panel/util/__init__.py 73.33% 4 Missing ⚠️
panel/links.py 0.00% 2 Missing ⚠️
panel/pane/holoviews.py 66.66% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7208      +/-   ##
==========================================
- Coverage   82.23%   81.99%   -0.25%     
==========================================
  Files         335      337       +2     
  Lines       49942    50364     +422     
==========================================
+ Hits        41071    41296     +225     
- Misses       8871     9068     +197     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

panel/__init__.py Outdated Show resolved Hide resolved
Base automatically changed from speed_import to main September 2, 2024 12:52
@philippjfr philippjfr added this to the v1.6.0 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants