Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we just ran
mypy
, this will make it so it fails if type testing fails. I have, set it up so you manually have to enable modules.Copied settings from: https://github.com/bokeh/bokeh/blob/bba83ab0db6986f5b8e82ab01e2ad2d09b877cea/pyproject.toml
Commented out strict for now, as it have many failing tests. Currently, I see two failing tests.
Currently two errors, the changes in the codebase is to fix other errors.