Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Governance] Custom Build Policies - Added Bicep framework #842

Merged
merged 15 commits into from
Aug 21, 2024

Conversation

JBakstPaloAlto
Copy link
Collaborator

Jira ticket: https://redlock.atlassian.net/browse/BCE-33806

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Aug 19, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to bicep-custom-policy August 19, 2024 11:06 Inactive
@JBakstPaloAlto JBakstPaloAlto added the documentation Improvements or additions to documentation label Aug 19, 2024
Copy link
Collaborator

@jenjoe22 jenjoe22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd suggest a minor change in the code-editor.adoc file. Please changes all lead sentences preceding tables. The current construction is a bit awkward.
"For instructions on how to use the type of Attribute with key and values see in the table." Maybe this instead, "The table below provides instructions on how to use Attributes with matching keys and values."

…om-build-policies/custom-build-policies.adoc

Co-authored-by: Taylor <[email protected]>
@aem-code-sync aem-code-sync bot temporarily deployed to bicep-custom-policy August 20, 2024 07:27 Inactive
…om-build-policies/visual-editor.adoc

Co-authored-by: Taylor <[email protected]>
@aem-code-sync aem-code-sync bot temporarily deployed to bicep-custom-policy August 20, 2024 07:27 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to bicep-custom-policy August 20, 2024 07:44 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to bicep-custom-policy August 20, 2024 08:27 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to bicep-custom-policy August 20, 2024 08:36 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to bicep-custom-policy August 20, 2024 11:40 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to bicep-custom-policy August 20, 2024 12:06 Inactive
…om-build-policies/visual-editor.adoc

Co-authored-by: Taylor <[email protected]>
@aem-code-sync aem-code-sync bot temporarily deployed to bicep-custom-policy August 21, 2024 05:35 Inactive
@JBakstPaloAlto JBakstPaloAlto merged commit c876d7a into main Aug 21, 2024
3 checks passed
@JBakstPaloAlto JBakstPaloAlto deleted the bicep-custom-policy branch August 21, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants