Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Runtime Security]Fix image rendering in fragments #377

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

rcaballeromx
Copy link
Contributor

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

This PR comments out the images in all fragments.
This is a workaround until the infrastructure issues preventing the images from rendering is solved. This PR can then be reverted.

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Feb 2, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@rcaballeromx rcaballeromx requested a review from jenjoe22 February 2, 2024 19:52
@rcaballeromx rcaballeromx self-assigned this Feb 2, 2024
@rcaballeromx rcaballeromx added bug Something isn't working documentation Improvements or additions to documentation labels Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

Preview URL(s):

Warning: 31 missing adoc reference(s) found:

Copy link
Collaborator

@jenjoe22 jenjoe22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I think this will help as a stop gap until we have a proper solution.

@rcaballeromx rcaballeromx merged commit ac7a07f into main Feb 5, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants