Skip to content

Commit

Permalink
incorporate review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Ritwik Srivastava authored and Ritwik Srivastava committed Sep 30, 2024
1 parent 8dc2f25 commit d850230
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions blocks/hotspot/hotspot.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ export default function decorate(block) {
[...block.children].forEach((row, r) => {
if (r > 0) {
const content = [...row.children][0].textContent.trim();
const isImage = content.endsWith('.jpg') || content.endsWith('.png') || content.endsWith('.gif') || content.endsWith('.jpeg');
const isVideo = content.endsWith('.mp4') || content.endsWith('.webm') || content.endsWith('play') || content.endsWith('content/'); // Adjust condition as needed
const isText = !isImage && !isVideo; // Assuming if it's neither image nor video, it's text
const variant = block.classList.value;
const isImageVariant = variant.includes('image') && !(variant.includes('video'));
const isVideoVariant = variant.includes('video') && !(variant.includes('image'));
const isTextVariant = !isImageVariant && !isVideoVariant;

const nexticondiv = document.createElement('div');
nexticondiv.classList.add('hotspot'); // Added class for CSS targeting
Expand All @@ -16,19 +17,19 @@ export default function decorate(block) {
const contentContainer = document.createElement('div');
contentContainer.classList.add('hotspot-content');

if (isImage) {
if (isImageVariant) {
const img = document.createElement('img');
img.src = content;
contentContainer.appendChild(img);
} else if (isVideo) {
} else if (isVideoVariant) {
const video = document.createElement('div');
video.innerHTML = `<div class="embed-default">
<iframe src=${content} from allow="encrypted-media" loading="lazy">
</iframe>
</div>`;
// above code can be updated for video controls such as autoplay, loop, etc.
contentContainer.appendChild(video);
} else if (isText) {
} else if (isTextVariant) {
contentContainer.textContent = content; // Display text
contentContainer.classList.add('bgborder');
}
Expand Down

0 comments on commit d850230

Please sign in to comment.