762 [Solutions] Block/UI download component #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 7, 2024 18:48
…o 762-ui-download-comp
…o 762-ui-download-comp
sharanagoudapatil
requested review from
mhaack,
rgravitvl and
davenichols-DHLS
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
rgravitvl
reviewed
Feb 9, 2024
blocks/download/download.js
Outdated
| row.querySelectorAll('picture').forEach((picItem) => { | ||
| picItem?.parentElement?.parentElement?.classList.add(...'w-full card flex flex-col md:flex-row py-4 gap-x-2 gap-y-4 items-start md:items-center'.split(' ')); | ||
| picItem?.parentElement?.classList.add(...'card-image flex'.split(' ')); | ||
| picItem?.classList.add(...'w-64 h-64 block md:w-56 md:h-40 rounded-md shrink-0 mb-3 md:mb-0 object-cover aspect-video'.split(' ')); |
There was a problem hiding this comment.
Height looks too much compare to original, may can be reduced. Even width also can be slightly reduced.
There was a problem hiding this comment.
@rgravitvl - I've updated the changes. please have a look. Thanks.
…o 762-ui-download-comp
mhaack
approved these changes
Feb 12, 2024
rgravitvl
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #762
Test URLs: