Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

310-converter-update-for-product-opco-pages #543

Merged
merged 4 commits into from
Dec 5, 2023
Merged

310-converter-update-for-product-opco-pages #543

merged 4 commits into from
Dec 5, 2023

Conversation

rgravitvl
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #310

Test URLs:

@rgravitvl rgravitvl linked an issue Dec 5, 2023 that may be closed by this pull request
[Products Opco] Converter update for product opco pages #310
Closed
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Dec 5, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@rgravitvl rgravitvl requested a review from mhaack December 5, 2023 06:58
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Dec 5, 2023

Page Scores Audits Google
/ Lighthouse returned error: FAILED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Details: net::ERR_CONNECTION_FAILED) PSI

mhaack
mhaack approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@mhaack mhaack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comments

styles/styles.css Outdated Show resolved Hide resolved
tools/actions/convert/test/fixtures/product-opco-home-converted.html Outdated Show resolved Hide resolved
davenichols-DHLS
davenichols-DHLS approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@davenichols-DHLS davenichols-DHLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, I see also Markus approved. Thanks.

@rgravitvl rgravitvl merged commit 7a4c67b into main Dec 5, 2023
2 of 3 checks passed
@rgravitvl rgravitvl deleted the 310-converter-update-for-product-opco-pages branch December 5, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davenichols-DHLS davenichols-DHLS davenichols-DHLS approved these changes

@mhaack mhaack mhaack approved these changes

@duynguyen duynguyen Awaiting requested review from duynguyen

@amlan18041996 amlan18041996 Awaiting requested review from amlan18041996

@sharanagoudapatil sharanagoudapatil Awaiting requested review from sharanagoudapatil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Products Opco] Converter update for product opco pages
3 participants
@rgravitvl @mhaack @davenichols-DHLS