Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for overview tab hide in products page if no response from api #1313

Merged
merged 12 commits into from
Dec 17, 2024

Conversation

lakshmithi
Copy link
Collaborator

@lakshmithi lakshmithi commented Nov 26, 2024

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #1313

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Nov 26, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Nov 26, 2024

Page Scores Audits Google
📱 /us/en/products/sku/ab272504-abcam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /us/en/products/sku/ab272504-abcam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@lakshmithi lakshmithi requested a review from rgravitvl November 26, 2024 16:22
@aem-code-sync aem-code-sync bot temporarily deployed to fix-overviewtab-hide November 26, 2024 16:29 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to fix-overviewtab-hide November 27, 2024 12:18 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to fix-overviewtab-hide November 27, 2024 12:52 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to fix-overviewtab-hide November 28, 2024 17:37 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to fix-overviewtab-hide December 2, 2024 06:42 Inactive
@davenichols-DHLS davenichols-DHLS self-requested a review December 2, 2024 15:06
@aem-code-sync aem-code-sync bot temporarily deployed to fix-overviewtab-hide December 5, 2024 08:51 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to fix-overviewtab-hide December 6, 2024 10:13 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to fix-overviewtab-hide December 16, 2024 17:18 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to fix-overviewtab-hide December 17, 2024 04:50 Inactive
@davenichols-DHLS davenichols-DHLS merged commit 926283b into main Dec 17, 2024
3 checks passed
@davenichols-DHLS davenichols-DHLS deleted the fix-overviewtab-hide branch December 17, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants