Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1215 Video Embed Converter Update #1216

Merged
merged 1 commit into from
Jul 19, 2024
Merged

1215 Video Embed Converter Update #1216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/actions/convert/test/fixtures/blog3-converted.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ <h1>Enabling Science at Scale: How Danaher Life Sciences partners deep with Biop
<div>
<div>
<p>
<img src="https://vimeo.com/api/oembed.json?url=https%3A//vimeo.com/vimeo.com/video/842870177,842870177" alt="">
<img src="https://vimeo.com/api/oembed.json?url=https%3A//vimeo.com/vimeo.com/video/842870177,842870177&#x26;width=480&#x26;height=360" alt="">
</p>
<p><a href="https://player.vimeo.com/video/842870177">https://player.vimeo.com/video/842870177</a></p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion tools/actions/convert/test/fixtures/product1-converted.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ <h2>Next-generation fluorescent imaging solution for the assurance of monoclonal
<tr>
<td>
<p>
<img src="http://share.vidyard.com/watch/WwWUddqbVhBk8jtmGQ6dHF.html" alt="">
<img src="http://share.vidyard.com/watch/WwWUddqbVhBk8jtmGQ6dHF.html&#x26;width=480&#x26;height=360" alt="">
</p>
<p><a href="https://play.vidyard.com/WwWUddqbVhBk8jtmGQ6dHF.html">https://play.vidyard.com/WwWUddqbVhBk8jtmGQ6dHF.html</a></p>
</td>
Expand Down
4 changes: 2 additions & 2 deletions tools/actions/convert/test/fixtures/product3-converted.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ <h2>No constraints - 4x more data with 100% correlation</h2>
<tr>
<td>
<p>
<img src="https://vimeo.com/api/oembed.json?url=https%3A//vimeo.com/vimeo.com/video/809017220,809017220" alt="">
<img src="https://vimeo.com/api/oembed.json?url=https%3A//vimeo.com/vimeo.com/video/809017220,809017220&#x26;width=480&#x26;height=360" alt="">
</p>
<p><a href="https://player.vimeo.com/video/809017220?h=c59cdbdab2;badge=0;autopause=0;player%5C_id=0;app%5C_id=58479">https://player.vimeo.com/video/809017220?h=c59cdbdab2;badge=0;autopause=0;player\_id=0;app\_id=58479</a></p>
</td>
Expand Down Expand Up @@ -108,7 +108,7 @@ <h2>No constraints - Achieve physiological-like conditions thoughout your experi
<tr>
<td>
<p>
<img src="https://vimeo.com/api/oembed.json?url=https%3A//vimeo.com/vimeo.com/video/809768643,809768643" alt="">
<img src="https://vimeo.com/api/oembed.json?url=https%3A//vimeo.com/vimeo.com/video/809768643,809768643&#x26;width=480&#x26;height=360" alt="">
</p>
<p><a href="https://player.vimeo.com/video/809768643?h=0814b7152d%5C&#x26;badge=0%5C&#x26;autopause=0%5C&#x26;player%5C_id=0%5C&#x26;app%5C_id=58479">https://player.vimeo.com/video/809768643?h=0814b7152d\&#x26;badge=0\&#x26;autopause=0\&#x26;player\_id=0\&#x26;app\_id=58479</a></p>
</td>
Expand Down
4 changes: 2 additions & 2 deletions tools/importer/transformers/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,9 +218,9 @@ const getVideoThumbnail = (url, quality) => {
if (type === 'youtube') {
thumbnail = `http://img.youtube.com/vi/${videoId}/${qualityKey}.jpg`;
} else if (type === 'vimeo') {
thumbnail = `https://vimeo.com/api/oembed.json?url=https%3A//vimeo.com/${videoId}`;
thumbnail = `https://vimeo.com/api/oembed.json?url=https%3A//vimeo.com/${videoId}&width=480&height=360`;
} else if (type === 'vidyard') {
thumbnail = `http://share.vidyard.com/watch/${videoId}`;
thumbnail = `http://share.vidyard.com/watch/${videoId}&width=480&height=360`;
} else {
thumbnail = false;
}
Expand Down
Loading