Skip to content

Commit

Permalink
fix for 1310 title issue and product overview tab issue
Browse files Browse the repository at this point in the history
  • Loading branch information
lakshmithi committed Dec 2, 2024
1 parent 2158704 commit 5f3b5b2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion blocks/page-tabs/page-tabs.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ function hasSpecifications(productResponse) {

function hasOverview(productResponse) {
const classVerify = document.querySelector('.product-overview-container, .columns-container')?.children;
if (classVerify.length === 0 && productResponse?.raw?.numattributes === 0) {
if (classVerify.length === 0 && productResponse?.raw?.richlongdescription.length === 0) {
return null;
}
return productResponse?.raw?.richlongdescription;
Expand Down
2 changes: 1 addition & 1 deletion tools/importer/transformers/productHero.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const createProductHero = async (main, document, param, url) => {
const product = main.querySelector('product-page');
if (product) {
const productCells = [
['Product Hero'],
['Product Not Found'],
];
const title = document.createElement('h1');
const titleVal = await getProductTitle(url, host);
Expand Down

0 comments on commit 5f3b5b2

Please sign in to comment.