Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 20240604 #37

Merged
merged 48 commits into from
Jun 4, 2024
Merged

Release 20240604 #37

merged 48 commits into from
Jun 4, 2024

Conversation

davenichols-DHLS
Copy link
Collaborator

amlan18041996 and others added 30 commits April 24, 2024 16:07
@amlan18041996
WIP: f227371 Merge pull request #1047 from hlxsites/1045-refactor-css…
a86696a 
…-page-jump-menu
@amlan18041996
WIP: a86696a WIP: f227371 Merge pull request #1047 from hlxsites/1045…
51867fd 
…-refactor-css-page-jump-menu
@amlan18041996
vertical alignment and horizontal stretch fixes
4070b4a
@amlan18041996
Merge branch 'main' into 1040-header-topic-pages
3991a48
@amlan18041996
Merge branch 'main' into 1040-header-topic-pages
634f9ac
@amlan18041996
Merge branch 'main' into 1040-header-topic-pages
c2c197b
1046 [Bug] On the workflow-carousel the icons don't always show
804692e
reverted eslintrc change
7491a59
1130 [Config] eslint error linebreak-style for window
1cff09a
@rgravitvl
Updated lint files
24a73a3
@rgravitvl
updated hlx and stylelint
54df078
@rgravitvl
Merge branch 'main' into 1130-linebreak-window
ed2c97d
@rgravitvl
Merge branch 'main' into 1046-workflow-icons
484447a
@rgravitvl
Merge pull request #1135 from hlxsites/update-lint-files
e5c6f40 
[FIX] Updated lint files
@rgravitvl
Minified the JS with Terser CLI
18ab194
@davenichols-DHLS
Amending the image to contain rather than cover
05498c7
1141 [ReBrand] Converter update for logo-cloud
7b4e863
reverted eslintrc
fdae33f
@sharanagoudapatil
Merge pull request #1131 from hlxsites/1130-linebreak-window
1af6fe1 
1130 [Config] eslint error linebreak-style for window
Merge branch 'main' of https://github.com/hlxsites/danaher-ls-aem int…
0201a78 
…o 1141-converter-logo-cloud
@sharanagoudapatil
Merge branch 'main' into 1046-workflow-icons
bf2dce4
@sharanagoudapatil
Merge pull request #1142 from hlxsites/1141-converter-logo-cloud
951bd4b 
1141 [ReBrand] Converter update for logo-cloud
@sharanagoudapatil
Merge pull request #1129 from hlxsites/1046-workflow-icons
5859330 
1046 [Bug] On the workflow-carousel the icons don't always show
@jckautzmann
[UE] enable the converter to skip some pages (#1100)
6fd6843 
* [UE] Implement UE support for "topics" pages

- makes test pages (containing -jck1) skip the converter and go though the pass-through pipeline
- pass-through pipeline: adds .html to the links in the page
- adds tests
@jckautzmann
[UE] make text blocks editable with Universal Editor (#1117)
5513809 
* [UE] Implement UE support for "topics" pages

- ports all changes from the xwalk boilerplate:
adobe/aem-boilerplate@main...adobe-rnd:aem-boilerplate-xwalk:main
- updates lib-franklin.js from the latest version of aem.js
[ReBrand] About Us and DBS Page redesign and implement in Crosswalk
17aaf82
@rgravitvl
Fixed height for jump menu
06e3398
1099 [Product] Product Recommendations click event not firing on Prod…
703be8c 
…uction
@rgravitvl
Merge pull request #1144 from hlxsites/1140-seo-product-page-cls-issue
d786e84 
Fixed height for jump menu for Product Details
@jckautzmann
[UE] pass-through converter: rewrite images (#1145)
dccbdd2 
* [UE] pass-through converter: rewrite images

- externalize image references so that the Helix Admin can generate image blobs
- fix breadcrumb editing
davenichols-DHLS and others added 16 commits May 29, 2024 10:13
@davenichols-DHLS
Merge pull request #1138 from hlxsites/1137-images-product-family-list
a3473ef 
1138 [Products] Product Family list image to contain rather than cover
@sharanagoudapatil
Merge branch 'main' into 1099-prod-recom-clickevent
06425e9
Merge branch 'main' of https://github.com/hlxsites/danaher-ls-aem int…
6ca442e 
…o 1133-about-us-rebrand
Added 5 secs delay to loadEmbed()
28dc02c
@sharanagoudapatil
Merge pull request #1146 from hlxsites/1099-prod-recom-clickevent
3831834 
1099 [Product] Product Recommendations click event not firing on Prod…
@davenichols-DHLS
embed-vimeo
0d714c3
@davenichols-DHLS
Merge pull request #1143 from hlxsites/1133-about-us-rebrand
63a771a 
1133 [ReBrand] About Us and DBS Page redesign and implement in Crosswalk
Merge branch 'main' of https://github.com/hlxsites/danaher-ls-aem int…
eaaf185 
…o 1132-seo-minify-franklin-script-js
@davenichols-DHLS
Merge pull request #1136 from hlxsites/1132-seo-minify-franklin-scrip…
04917c2 
…t-js

1132 [SEO] Minified the JS with Terser CLI
1149 [Product] Product Recommendations click event source is missing
55840f1
@sharanagoudapatil
Merge pull request #1150 from hlxsites/1149-prod-recom-source
4888dba 
1149 [Product] Product Recommendations click event source is missing
@amlan18041996
Merge branch 'main' into 1040-header-topic-pages
e68e229
@amlan18041996
Merge branch 'main' into 1040-header-topic-pages
85e7ef2
@sharanagoudapatil
Merge pull request #1066 from hlxsites/1040-header-topic-pages
dabd922 
1040 Topic's header ReBrand changes
1151 [Bug] jump-menu dropdown displayed on desktop view on Solutions …
95a3e92 
…page
@sharanagoudapatil
Merge pull request #1152 from hlxsites/1151-jump-menu-dropdown
2a7ed4d 
1151 [Bug] jump-menu dropdown displayed on desktop view on Solutions …
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jun 4, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jun 4, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

sharanagoudapatil
sharanagoudapatil approved these changes Jun 4, 2024
View reviewed changes
Copy link

@sharanagoudapatil sharanagoudapatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks.

@davenichols-DHLS davenichols-DHLS merged commit de6f3f2 into hlxsites:main Jun 4, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharanagoudapatil sharanagoudapatil sharanagoudapatil approved these changes

@rgravitvl rgravitvl rgravitvl approved these changes

@mhaack mhaack Awaiting requested review from mhaack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davenichols-DHLS @rgravitvl @sharanagoudapatil @amlan18041996 @jckautzmann