forked from hlxsites/danaher-ls-aem
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 20240520 #34
Merged
Merged
Release 20240520 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1074 Merged Footer CSS to JS
968 [SEO] Do we still need Typekit?
1017 [SEO] Remove We See code and library
* [UE] Implement UE support for "topics" pages - add support for page metadata, accordion, takeaway and call-to-action blocks --------- Co-authored-by: Dirk Rudolph <[email protected]>
[BUG] Fixed heading issues and Product Hero CLS
FIX - Cleaned up all build CSS
[FIX] Home page nav bar CLS issue
- support CTA with 2 buttons
- use aem-content instead of reference (as reference is used for images)
Removed JavaScript minification
[Bug] Timeline block h2 element broken
…vents 1033 updating coveo events
1122 [Bug] Jump-Menu and Page-Tabs UI broken when scroll down
davenichols-DHLS
requested review from
rgravitvl,
amlan18041996 and
sharanagoudapatil
May 20, 2024 10:49
|
rgravitvl
approved these changes
May 20, 2024
sharanagoudapatil
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: