LYNX-718: Sidekick Personalisation plugin - Catalog Rules, Cart Rules and Customer Groups #287
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
tools/segments/src/index.js
Outdated
| 'key': 'catalogRules', | ||
| 'title': 'Catalog Rules', | ||
| 'initializer': getCatalogRules, | ||
| }, | ||
| // { | ||
| // 'key': 'utmParams', |
There was a problem hiding this comment.
We don't have to list utm_params in the plugin
There was a problem hiding this comment.
This is just a placeholder based on the description from https://jira.corp.adobe.com/browse/LYNX-671, removed for now.
| 'Content-Type': 'application/json', | ||
| 'x-api-key': config['commerce.headers.cs.x-api-key'], | ||
| 'Magento-Customer-Group': config['commerce.headers.cs.Magento-Customer-Group'], | ||
| 'Magento-Environment-Id': config['commerce.headers.cs.Magento-Environment-Id'], |
There was a problem hiding this comment.
Not all headers are neccessary for Adobe Commerce
There was a problem hiding this comment.
Removed unnecessary headers.
| 'Magento-Website-Code': config['commerce.headers.cs.Magento-Website-Code'], | ||
| }; | ||
|
|
||
| const apiCall = new URL(config['commerce-core-endpoint']); |
There was a problem hiding this comment.
I'd use import { getConfigValue } from '../../scripts/configs.js'; and await getConfigValue('commerce-core-endpoint')
This PR implements selection for Customer Groups, Catalog Rules and Cart Rules in Sidekick Personalisation Plugin
See https://jira.corp.adobe.com/browse/LYNX-718 for details
Test URLs: