Multi source support for commerce configs and placeholders #286
+90
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
fnhipster
changed the title
…support and remove unused preload link
…fragments from indexing
…te session storage keys
sirugh
reviewed
Jan 30, 2025
Co-authored-by: Stephen <[email protected]>
sirugh
reviewed
Jan 30, 2025
… as the default - decorate links for EDS pages - localize links for Blocks
sirugh
reviewed
Jan 31, 2025
| const links = main.querySelectorAll('a'); | ||
|
|
||
| links.forEach((link) => { | ||
| if (link.href.startsWith('//' || link.href.startsWith(root))) return; |
There was a problem hiding this comment.
Suggested change
| if (link.href.startsWith('//' || link.href.startsWith(root))) return; | |
| if (link.href.startsWith('//') || link.href.startsWith(root))) return; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides Commerce endpoint configs and placeholders based on the
rootpage metadata provided. Otherwise, it defaults to the base/.Metadata are managed as a bulk (https://www.aem.live/docs/bulk-metadata) in metadata.xlsx.
root: path to whereconfigs.xlsxfiles are located. default/](root: Path to the directory where configs.xlsx files are located. Default is /.)placeholders: path to the placeholders.json filer to use. default/placeholders.json. By adding a path in a new line in this value adds an override file where both paths will be fetch and the values of the second will override the first.](placeholders: Path to the placeholders.json file to use. Default is /placeholders.json. Adding a new line with another path in this value specifies an override file. Both files will be fetched, and the values in the second file will override those in the first.)☑️ TODO
root/drafts/multistore/*only have theindexat the moment.https://multistore--aem-boilerplate-commerce--hlxsites.hlx.page/
https://multistore--aem-boilerplate-commerce--hlxsites.hlx.page/drafts/multistore/en/
https://multistore--aem-boilerplate-commerce--hlxsites.hlx.page/drafts/multistore/en_ca/
Test URLs: