Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync to Stage: PM-806: Add default Pumpkin Wellness cta_location for DL #310

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

pgilmore-phi
Copy link
Collaborator

Jira Ticket

PM-806

Purpose

On some CTA clicks triggering the trackGTMEvent, we are missing the cta_location in DataLayer.

Changes

There is some custom logic set up in instrumentTrackingEvents() which is not setting the cta_location, due to some CTA's being authored outside of blocks.

  • As a fallback, we are now going to capture the closest section as the location when the CTA has not met any of the existing conditionals.
  • The header is missing cta_location, this has been added in.

Validate Changes

Review https://pethealthinc.atlassian.net/browse/PM-806 for validation steps.

Before: https://stage--24petwatch--hlxsites.hlx.page
After: https://feature-pm-806-cta-click-dl--24petwatch--hlxsites.hlx.page/

Copy link

aem-code-sync bot commented Jan 10, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 10, 2025

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@pgilmore-phi pgilmore-phi merged commit 76a80ab into stage Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants