Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync costco figo changes to develop #289

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

pgilmore-phi
Copy link
Collaborator

@pgilmore-phi pgilmore-phi commented Nov 25, 2024

Jira Ticket

PM-375

Changes

Updated subId value in COSTCO_FIGO_PROMO_ITEMS

Validate Changes

See all validation requirements on each task under epic: https://pethealthinc.atlassian.net/browse/PM-375

* Initial setup for Costco Figo campaign

* PM-367: Added form and summary logic accomodating promo requirements

* PM-367: Updated logic based on multipet and active promo

* PM-367: Added checks on multipet to identify if we need to clear cookie and data

* PM-367: Added method to disable field, prevent any mouse interactions and disable focus

* PM-367: Added nullish checks on summary page

* PM-367: removing edits to eslint

* PM-367: Adding env config for service

* PM-367: Updated config to proxy service

* PM-367: moving reset method into costo-promo.js

* PM-367: adding removed comment back

* PM-367: remove unnecessary additional check on policyId
* Initial setup for Costco Figo campaign

* PM-367: Added form and summary logic accomodating promo requirements

* PM-367: Updated logic based on multipet and active promo

* PM-367: Added checks on multipet to identify if we need to clear cookie and data

* PM-367: Added method to disable field, prevent any mouse interactions and disable focus

* PM-367: Added nullish checks on summary page

* PM-367: removing edits to eslint

* PM-367: Adding env config for service

* PM-367: Updated config to proxy service

* PM-367: moving reset method into costo-promo.js

* PM-367: adding removed comment back

* PM-367: remove unnecessary additional check on policyId

* PM-367: Updating subid value for costco figo
Copy link

aem-code-sync bot commented Nov 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to release/costco-figo-promotion November 25, 2024 21:11 Inactive
@pgilmore-phi pgilmore-phi changed the title Release/costco figo promotion Sync costco figo changes to develop Nov 25, 2024
Copy link
Collaborator

@hero-dokane hero-dokane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pgilmore-phi pgilmore-phi merged commit aac3c9e into develop Nov 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants