generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-375: Costco Figo Promotion #283
Merged
hero-dokane
merged 12 commits into
release/costco-figo-promotion
from
feature/PM-367-costco-figo
Nov 21, 2024
Merged
PM-375: Costco Figo Promotion #283
hero-dokane
merged 12 commits into
release/costco-figo-promotion
from
feature/PM-367-costco-figo
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and disable focus
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
aem-code-sync
bot
temporarily deployed
to
feature/PM-367-costco-figo
November 20, 2024 21:31
Inactive
aem-code-sync
bot
temporarily deployed
to
feature/PM-367-costco-figo
November 20, 2024 21:35
Inactive
aem-code-sync
bot
temporarily deployed
to
feature/PM-367-costco-figo
November 21, 2024 15:59
Inactive
hero-dokane
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
hero-dokane
merged commit Nov 21, 2024
76a4238
into
release/costco-figo-promotion
1 of 2 checks passed
hero-dokane
pushed a commit
that referenced
this pull request
Nov 21, 2024
* Initial setup for Costco Figo campaign * PM-367: Added form and summary logic accomodating promo requirements * PM-367: Updated logic based on multipet and active promo * PM-367: Added checks on multipet to identify if we need to clear cookie and data * PM-367: Added method to disable field, prevent any mouse interactions and disable focus * PM-367: Added nullish checks on summary page * PM-367: removing edits to eslint * PM-367: Adding env config for service * PM-367: Updated config to proxy service * PM-367: moving reset method into costo-promo.js * PM-367: adding removed comment back * PM-367: remove unnecessary additional check on policyId
pgilmore-phi
added a commit
that referenced
this pull request
Nov 25, 2024
* Initial setup for Costco Figo campaign * PM-367: Added form and summary logic accomodating promo requirements * PM-367: Updated logic based on multipet and active promo * PM-367: Added checks on multipet to identify if we need to clear cookie and data * PM-367: Added method to disable field, prevent any mouse interactions and disable focus * PM-367: Added nullish checks on summary page * PM-367: removing edits to eslint * PM-367: Adding env config for service * PM-367: Updated config to proxy service * PM-367: moving reset method into costo-promo.js * PM-367: adding removed comment back * PM-367: remove unnecessary additional check on policyId
pgilmore-phi
added a commit
that referenced
this pull request
Nov 25, 2024
* PM-375: Costco Figo Promotion (#283) * Initial setup for Costco Figo campaign * PM-367: Added form and summary logic accomodating promo requirements * PM-367: Updated logic based on multipet and active promo * PM-367: Added checks on multipet to identify if we need to clear cookie and data * PM-367: Added method to disable field, prevent any mouse interactions and disable focus * PM-367: Added nullish checks on summary page * PM-367: removing edits to eslint * PM-367: Adding env config for service * PM-367: Updated config to proxy service * PM-367: moving reset method into costo-promo.js * PM-367: adding removed comment back * PM-367: remove unnecessary additional check on policyId * PM-367: Update to SUBID value for COSTCO FIGO (#288) * Initial setup for Costco Figo campaign * PM-367: Added form and summary logic accomodating promo requirements * PM-367: Updated logic based on multipet and active promo * PM-367: Added checks on multipet to identify if we need to clear cookie and data * PM-367: Added method to disable field, prevent any mouse interactions and disable focus * PM-367: Added nullish checks on summary page * PM-367: removing edits to eslint * PM-367: Adding env config for service * PM-367: Updated config to proxy service * PM-367: moving reset method into costo-promo.js * PM-367: adding removed comment back * PM-367: remove unnecessary additional check on policyId * PM-367: Updating subid value for costco figo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
PM-375
Purpose
Under the epic PM-375 these changes are for all tasks related to the FE flow for a Costco Figo promotion
Changes
See all tasks under https://pethealthinc.atlassian.net/browse/PM-375
Validate Changes
See all validation requirements on each task under epic: https://pethealthinc.atlassian.net/browse/PM-375
Example valid policy from inbound email link: https://feature-pm-367-costco-figo--24petwatch--hlxsites.hlx.page/lost-pet-protection/annual-quote?poid=0YTVE000000gbZR4AY
To test invalid, change any characters in value
Before: https://main--24petwatch--hlxsites.hlx.page/lost-pet-protection/annual-quote
After: https://feature-pm-367-costco-figo--24petwatch--hlxsites.hlx.page/lost-pet-protection/annual-quote