Skip to content

Conversation

@BSDKaffee
Copy link
Contributor

Clean up after e061ca9 and 1039035 because of e7dd572. So, e7dd572 should have included a Qt version check. e061ca9 adds this check and fixes build with Qt <= 6.9, but there is no QT_VERSION variable defined in the Qt CMake configs. This again breaks Qt >= 6.10. So, 1039035 does some creative things to make the build work again with Qt 6.10, but this is misguided and non-standard. All that needs be done is to compare Qt6_VERSION (case sensitive) in src/platform/x11/x11platform.cmake.

@BSDKaffee BSDKaffee requested a review from hluk as a code owner December 1, 2025 11:21
@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.90%. Comparing base (7934ae6) to head (4c48dc3).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3339   +/-   ##
=======================================
  Coverage   79.89%   79.90%           
=======================================
  Files         231      231           
  Lines       28469    28469           
=======================================
+ Hits        22746    22747    +1     
+ Misses       5723     5722    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hluk hluk merged commit 5bd157c into hluk:master Dec 7, 2025
12 checks passed
@hluk
Copy link
Owner

hluk commented Dec 7, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants