Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the metadata to satisfy the need of HMA #165

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

sjh120
Copy link
Collaborator

@sjh120 sjh120 commented Mar 22, 2024

Description

Motivation and Context

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@MooooCat
Copy link
Contributor

Hi @sjh120 ,

At present, we can find that some unit tests still report errors (checks -> python package / build ).

Here are my suggestions:

  • Please solve these error problems first and pass all unit tests;
  • Please add unit tests for the newly added code to ensure that the newly added functions run well and maintain unit test coverage.

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 38.80597% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 79.25%. Comparing base (861f5b6) to head (6fd80b6).
Report is 1 commits behind head on main.

Files Patch % Lines
sdgx/data_models/metadata.py 37.50% 40 Missing ⚠️
sdgx/data_models/combiner.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   80.09%   79.25%   -0.84%     
==========================================
  Files          69       69              
  Lines        3305     3370      +65     
==========================================
+ Hits         2647     2671      +24     
- Misses        658      699      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +210 to +221
def _get_primary_and_alternate_keys(self):
"""Get set of primary and alternate keys.

Returns:
set:
Set of keys.
"""
keys = set(self.alternate_keys)
if self.primary_key:
keys.update({self.primary_key})

return keys
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you ever test this function? Not sure whether primary_key is a dict..If so, we may need to chang the name

@Wh1isper
Copy link
Collaborator

Wh1isper commented Apr 4, 2024

I notice that warnings.warn is used here, but it's not necessary compared to log.warning.

How do you think here?

@MooooCat
Copy link
Contributor

MooooCat commented Apr 4, 2024

I notice that warnings.warn is used here, but it's not necessary compared to log.warning.

Sure, only use log.warning is enough.

I' will change the code, there are still some flaws in this PR.

@jalr4ever
Copy link
Collaborator

This PR has been stalled for a while, and it lacks enough background info, like motication and descreiption. Do you guys know what's going on now ? @MooooCat @Wh1isper

@Wh1isper
Copy link
Collaborator

@jalr4ever I'm not sure, it may have something to do with the new model that is planned to be developed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants