Fix/Todo-list #189
Fix/Todo-list #189
Conversation
There was a problem hiding this comment.
Improvements
The original code has an issue with string concatenation logic. The condition should be evaluated correctly within the string interpolation.
Improvement: The use of string interpolation directly inside the template literal ensures clarity and correctness.
| @@ -100,7 +100,7 @@ const toggleTodoDoneStatus = asyncHandler(async (req, res) => { | |||
| new ApiResponse( | |||
| 200, | |||
| todo, | |||
| "Todo marked " + todo.isComplete ? "done" : "undone" | |||
| "Todo marked " + `${todo.isComplete ? "done" : "undone"}` | |||
There was a problem hiding this comment.
The original code has an issue with string concatenation logic. The condition should be evaluated correctly within the string interpolation.
Improvement: The use of string interpolation directly inside the template literal ensures clarity and correctness.
| updateTodoValidator, | ||
| getAllTodosQueryValidators, | ||
| }; | ||
| export { createTodoValidator, updateTodoValidator, getAllTodosQueryValidators }; |
There was a problem hiding this comment.
Let's keep the formatting as is for unchanged lines.
|
Kindly go through requested changes. Also, resolve conflicts. Thank you! |
correction in message inside validator and response message inside controller