Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

feat: add decode-price-feeds to oracle #31

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

lgalabru
Copy link
Contributor

@lgalabru lgalabru commented Dec 27, 2023

Addressing #30 - this function is adding the ability for the oracle to decode PNAU messages without updating the price feed store.
Note that this is a contract upgrade, so a PTGM message, upgrading the contract will have to be issued after the deployment.

As discussed, we're also getting rid of the helper contract.

@jakob-btc
Copy link

Thanks for the quick turnaround @lgalabru.

@ali-bahjati - can you give me a rough estimate of when we should expect this on mainnet? We are waiting for this upgrade before integrating Pyth into our contracts.

@jakob-btc
Copy link

@ali-bahjati - an understanding of the ETA for this PR to get merged would be very helpful to us. This is a key dependency for us to use Pyth on mainnet.

We can deploy the new contracts ourselves but would rather use the official release by you.

@ali-bahjati
Copy link
Contributor

ali-bahjati commented Jan 6, 2024

Hi @Gandalf77,
Sorry for my delay here. I will address this and make sure it is deployed early next week (the coming Monday/Tuesday). Would that work for you?

@ali-bahjati ali-bahjati merged commit 3afb7a8 into main Jan 9, 2024
2 checks passed
@jakob-btc
Copy link

That works, thanks @ali-bahjati!

@jakob-btc
Copy link

Hey @ali-bahjati - can you please ping me here when the new contracts are deployed? Thank you.

@Patotking12
Copy link

@Gandalf77 have you been able to make the Pyth Oracle work in your smart Contracts?

@jakob-btc
Copy link

@lgalabru, @ali-bahjati

When I call decode-price-feeds in pyth-oracle-v2 from our contracts like so

Screenshot from 2024-02-18 16-03-15

I get (err u4004) which I assume is ERR_UNAUTHORIZED_ACCESS from the .pyth-governance-v1 contract.

How can I remedy this? Are the contracts setup to be called by other contracts, since you're using contract-caller instead of tx-sender?

@jakob-btc
Copy link

@Gandalf77 have you been able to make the Pyth Oracle work in your smart Contracts?

Not yet, no. Have you?

@jakob-btc
Copy link

@Patotking12 - we got Pyth to work in our contracts. Reach out on Discord (@jakob_btc) if you need help with your implementation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants