feat: parsing for NakamotoCoinbase tx type #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not finding the length prefixed encoding for the VRF proof in the node code, where did you get this from? 🤔 |
|
Ok found it, I think the node meant to use different code, will open a PR |
|
Looks good 👍 but I'll wait with approving until I know more on stacks-network/stacks-core#4115 If you need it sooner, lmk |
|
@janniks I had the same thought. We'll wait to see if it's intended. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing parsing for the new
NakamotoCoinbasetx type. This tx type is mentioned in passing in SIP-021, the actual wire format is sourced from code here:https://github.com/stacks-network/stacks-core/blob/05274b6366a1e29ab363fe294745ff813d70985f/stackslib/src/chainstate/stacks/transaction.rs#L275-L292
Test vector generated from a mockamoto node.