feat: allow configuring k8s context with env var #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieC3
reviewed
Sep 25, 2023
Codecov Report
@@ Coverage Diff @@
## develop #71 +/- ##
==========================================
Coverage ? 79.64%
==========================================
Files ? 11
Lines ? 1076
Branches ? 0
==========================================
Hits ? 857
Misses ? 219
Partials ? 0 |
MicaiahReid
temporarily deployed
to
Development
GitHub Actions
Inactive
MicaiahReid
had a problem deploying
to
Staging
GitHub Actions
Failure
blockstack-devops
pushed a commit
that referenced
this pull request
Mar 25, 2024
## [1.1.0](v1.0.0...v1.1.0) (2024-03-25) ### Features * allow config path to be configured via env var ([#67](#67)) ([483fb8b](483fb8b)) * allow configuring k8s context with env var ([#71](#71)) ([f7e6bc3](f7e6bc3)) * check auth header before allowing access ([#47](#47)) ([6dcb36d](6dcb36d)) * remove pods; implement deployments/stateful sets ([#75](#75)) ([6399c19](6399c19)) * status page at `GET /` and `GET /api/v1/status` routes ([#68](#68)) ([d4c2290](d4c2290)) * upgrade clarinet to v2.4.0; enable `use_nakamoto` field to configure stacks chain for nakamoto ([#89](#89)) ([521acd1](521acd1)) * upgrade to using clarinet crate to parse config ([#46](#46)) ([d57d3a1](d57d3a1)) ### Bug Fixes * add ACCESS_CONTROL_ALLOW_HEADERS to response header ([#52](#52)) ([225d2c9](225d2c9)) * add subPath for postgres volume mount ([#73](#73)) ([7812741](7812741)) * api container spelling fix ([7b52f93](7b52f93)) * don't require auth on OPTIONS requests; configure user-id prefix to make namespace ([#51](#51)) ([9fe7972](9fe7972)) * reduce permissions for cluster role ([#54](#54)) ([2ea50ea](2ea50ea)) * removing untemplated labels ([#82](#82)) ([e92dcb5](e92dcb5)) * set img pull policy for stacks blockchain api ([0b959c2](0b959c2)) * template ([#85](#85)) ([4399177](4399177))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the hosts default context was always used for starting the API and running tests. This can potentially be dangerous, especially if a user is running tests locally and forgets that production contexts are currently set as their default.
This PR allows configuring the context with the
KUBE_CONTEXTenvironment variable. If no context is set, the host's default context is still used, unless running tests, in which case the contextkind-kindis used.Checklist