Skip to content

Commit

Permalink
chore: remove image pull secret for public registry (#57)
Browse files Browse the repository at this point in the history
  • Loading branch information
MicaiahReid authored Sep 21, 2023
1 parent 3795298 commit ef1ebde
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ jobs:
run: |
cargo install cargo-tarpaulin
cargo --version
cargo tarpaulin --out Lcov
cargo tarpaulin --out lcov
- name: Upload to codecov.io
uses: codecov/codecov-action@v2
Expand Down
7 changes: 1 addition & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,8 @@ The `Config.toml` at the root directory of the project can be used to control so
- `allowed_methods` - this setting is an array of strings that sets what HTTP methods can be made to this server.

## Deploying the Stable Version
First, you'll need to use your docker credentials to be able to pull the docker image. To create the needed secret, in your terminal run:
```
kubectl create secret --namespace devnet docker-registry stacks-devnet-api-secret --docker-server=https://index.docker.io/v1/ --docker-username=<user> --docker-email=<email> --docker-password=<password>
```
and enter in the details for a docker user that has access to the `hirosystems/stacks-devnet-api` image.

Then, in your terminal, run
In your terminal, run
```
./scripts/deploy-api.sh
```
Expand Down
2 changes: 0 additions & 2 deletions templates/stacks-devnet-api.template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ metadata:
namespace: devnet
spec:
serviceAccountName: stacks-devnet-api-service-account
imagePullSecrets:
- name: stacks-devnet-api-secret
containers:
- command: ["stacks-devnet-api"]
name: stacks-devnet-api-container
Expand Down

0 comments on commit ef1ebde

Please sign in to comment.