Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: number field in rune response #35

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

tippenein
Copy link
Contributor

@tippenein tippenein commented Jul 23, 2024

@tippenein tippenein changed the base branch from main to develop July 23, 2024 00:41
Copy link

github-actions bot commented Jul 23, 2024

Vercel deployment URL: https://runehook-k8mnii48m-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Files Patch % Lines
api/src/pg/pg-store.ts 25.00% 3 Missing ⚠️
api/src/api/util/helpers.ts 50.00% 1 Missing ⚠️
api/src/pg/types.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@xrem
Copy link

xrem commented Jul 23, 2024

@tippenein Didn't you forgot about SQL queries?
image

@tippenein
Copy link
Contributor Author

@xrem Yes! Thanks. Need more tests on this. Those are added now tho

@tippenein tippenein mentioned this pull request Jul 23, 2024
@tippenein tippenein force-pushed the feat/rune-number-response branch from 339d63c to d5a963d Compare July 23, 2024 19:21
@smcclellan smcclellan requested a review from rafaelcr July 29, 2024 15:58
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaelcr rafaelcr merged commit 4485057 into develop Jul 29, 2024
8 of 9 checks passed
@rafaelcr rafaelcr deleted the feat/rune-number-response branch July 29, 2024 16:05
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
## [0.3.0-beta.5](v0.3.0-beta.4...v0.3.0-beta.5) (2024-07-29)

### Features

* number field in rune response ([#35](#35)) ([4485057](4485057))
Copy link

🎉 This PR is included in version 0.3.0-beta.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
## [0.3.0](v0.2.2...v0.3.0) (2024-07-29)

### Features

* add zeromq streaming and rollback support ([#8](#8)) ([c201bb5](c201bb5))
* address activity endpoint ([#18](#18)) ([c6b8bbe](c6b8bbe))
* number field in rune response ([#35](#35)) ([4485057](4485057))

### Bug Fixes

* cached output balance retrieval ([#16](#16)) ([b87b921](b87b921))
* default output selection without a runestone ([#23](#23)) ([016583c](016583c))
* increase activity count when etching ([#14](#14)) ([e797fc3](e797fc3))
* move unallocated without need for a runestone ([#22](#22)) ([69559e0](69559e0))
* open and close pg connections for each chainhook message ([#15](#15)) ([3c93671](3c93671))
* register receive operations correctly on edicts ([#21](#21)) ([de48a59](de48a59))
Copy link

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants