Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update cargo files using exec plugin #2

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Conversation

CharlieC3
Copy link
Member

Uses the exec plugin to update the Cargo files instead of the semantic-release-cargo plugin.

@CharlieC3 CharlieC3 requested a review from rafaelcr June 29, 2024 13:45
@CharlieC3 CharlieC3 self-assigned this Jun 29, 2024
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@rafaelcr
Copy link
Collaborator

Thanks @CharlieC3 ! We would need to add manual steps to upload the built crate to crates.io in this case, though, right?

@CharlieC3
Copy link
Member Author

Oh I didn't think you wanted it uploaded to crates.io. If you do then we should keep the current plugin and give it creds to upload.

@rafaelcr
Copy link
Collaborator

You're right @CharlieC3 , we don't need to upload to crates.io ... we don't do it for ordhook either, just for the chainhook-sdk

Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafaelcr rafaelcr merged commit 005bacd into main Jun 30, 2024
7 checks passed
@rafaelcr rafaelcr deleted the ci/fix-sem-rel branch June 30, 2024 02:35
Copy link

github-actions bot commented Jul 1, 2024

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants